[webkit-reviews] review requested: [Bug 64459] vebview should use gtk-dnd-drag-threshold setting : [Attachment 100718] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jul 13 15:13:24 PDT 2011
arno. <arno at renevier.net> has asked for review:
Bug 64459: vebview should use gtk-dnd-drag-threshold setting
https://bugs.webkit.org/show_bug.cgi?id=64459
Attachment 100718: patch
https://bugs.webkit.org/attachment.cgi?id=100718&action=review
------- Additional Comments from arno. <arno at renevier.net>
(In reply to comment #1)
> (In reply to comment #0)
> > Hi,
> > gtk defines a gtk-dnd-drag-threshold property, and many gtk widgets use it
to prevent drag from starting when user moves mouse with a really small
movement. This is really important for accessibility (think, ill or old people
whose hands shake a lot).
> > I would be nice if WebKitWebView would not start a drag if
gtk_drag_check_threshold returns false.
>
>
> The drag hysteresis is controlled via constants in EventHandler.cpp. In GTK+
we could potentially make them depend on GTK+ settings. Another option would be
to make drag-and-drop a runtime setting, versus simply compile time. Do you
mind explaining your usecase?
My current usecase is building a minimal browser. Right click and drag must be
disabled. As far as I known, right click can be disabled on the system, but
drag cannot. Using has also some advantages: it would be possible to put a high
threshold, a make a browser more appropriated for people with some
disabilities. Then it's more coherent with other gkt widgets.
I attach a patch wich checks gtk-dnd-drag-threshold property, and makes uses it
if it's bigger than *DragHysteresis constants. To get the GtkWidget, I used the
logic from widgetFromFrame (PasteboardHelper.cpp). I wonder if there is some
util file where that function could go.
More information about the webkit-reviews
mailing list