[webkit-reviews] review granted: [Bug 64305] Move XML errors handling out from XMLDocumentParser (refactoring). : [Attachment 100354] Patch (comments addressed + qt build fix)

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 64305: Move XML errors handling out from XMLDocumentParser (refactoring).
https://bugs.webkit.org/show_bug.cgi?id=64305

Attachment 100354: Patch (comments addressed + qt build fix)
https://bugs.webkit.org/attachment.cgi?id=100354&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=100354&action=review


> Source/WebCore/xml/XMLErrors.cpp:85
> +    RefPtr<Element> h3 = doc->createElement(h3Tag, false);
> +    reportElement->appendChild(h3.get(), ec);

Can there be mutation event registered in doc to screw us over?

> Source/WebCore/xml/XMLErrors.h:59
> +    String m_errorMessages;

Consider using StringBuilder instead.  (See Darin's recent post on webkit-dev.)