[webkit-reviews] review denied: [Bug 64480] Speed up RenderLayer::updateLayerPositions when scrolling : [Attachment 100708] Proposed fix 1: Use scroll delta to avoid some rect recomputation.

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 64480: Speed up RenderLayer::updateLayerPositions when scrolling
https://bugs.webkit.org/show_bug.cgi?id=64480

Attachment 100708: Proposed fix 1: Use scroll delta to avoid some rect
recomputation.
https://bugs.webkit.org/attachment.cgi?id=100708&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=100708&action=review


r- due to fixed position issue.

> Source/WebCore/rendering/RenderLayer.cpp:287
> +    if (scrollDelta && (renderer()->style()->position() == FixedPosition ||
m_visibleContentStatusDirty))
> +	   scrollDelta = 0;

What if some ancestor is fixed position?