[webkit-reviews] review granted: [Bug 58762] localStorage string values truncated at \x00 characters on browser restart : [Attachment 100681] patch

[bugzilla-daemon at webkit.org]

Jeremy Orlow <jorlow at webkit.org> has granted Jonathan Dong
<jonathan.dong at torchmobile.com.cn>'s request for review:
Bug 58762: localStorage string values truncated at \x00 characters on browser
restart
https://bugs.webkit.org/show_bug.cgi?id=58762

Attachment 100681: patch
https://bugs.webkit.org/attachment.cgi?id=100681&action=review

------- Additional Comments from Jeremy Orlow <jorlow at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=100681&action=review


A few suggestions to make things more clear.

> Source/WebCore/storage/StorageAreaSync.cpp:276
> +	   SQLiteStatement query(m_database, "SELECT value FROM ItemTable LIMIT
1");

Add a comment to note that this query isn't ever executed.

> Source/WebCore/storage/StorageAreaSync.cpp:298
> +	       ASSERT_NOT_REACHED();

Maybe put this between the comment and the if statement since the comment
partially explains this too.

> Source/WebCore/storage/StorageAreaSync.cpp:300
> +	       // finally it will try to save the ItemTable by renaming it, for
manually restore in the future.

nit: It's nice to puse proper sentences.

> Source/WebCore/storage/StorageAreaSync.cpp:301
> +	       // NOTICE: this will eventually DELETE the current database, but
that's better

Did you mean "essentially"?