[webkit-reviews] review denied: [Bug 56401] hover then un-hover makes state change : [Attachment 99800] Patch 4
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jul 13 11:37:20 PDT 2011
Dave Hyatt <hyatt at apple.com> has denied Mihnea Ovidenie <mihnea at adobe.com>'s
request for review:
Bug 56401: hover then un-hover makes state change
https://bugs.webkit.org/show_bug.cgi?id=56401
Attachment 99800: Patch 4
https://bugs.webkit.org/attachment.cgi?id=99800&action=review
------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=99800&action=review
> Source/WebCore/rendering/RenderObjectChildList.cpp:413
> + if ((type == BEFORE) && insertBefore && insertBefore->isAnonymousBlock()
&& insertBefore->childrenInline()) {
Isn't (type == BEFORE) unnecessary in this if statement? insertBefore will be 0
if type is not == BEFORE.
More information about the webkit-reviews
mailing list