[webkit-reviews] review denied: [Bug 64444] [CSSRegions]Parse -webkit-region-overflow property : [Attachment 100672] Patch

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied Mihnea Ovidenie <mihnea at adobe.com>'s
request for review:
Bug 64444: [CSSRegions]Parse -webkit-region-overflow property
https://bugs.webkit.org/show_bug.cgi?id=64444

Attachment 100672: Patch
https://bugs.webkit.org/attachment.cgi?id=100672&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=100672&action=review


Minor nits with the enum.

> Source/WebCore/css/CSSPrimitiveValueMappings.h:1358
> +    switch (m_value.ident) {

Fix the style issues with the switch statements here.

> Source/WebCore/rendering/style/RenderStyleConstants.h:441
> +#if ENABLE(CSS_REGIONS)
> +enum ERegionOverflow { ROAuto, ROBreak };
> +#endif

This is really an obsolete style that we haven't gotten around to eliminating.
Just do this instead:

enum RegionOverflow { AutoRegionOverflow, BreakRegionOverflow };