[webkit-reviews] review granted: [Bug 64455] TestFailures page doesn't show as much information for flaky tests as I would like, even though the page is already so long : [Attachment 100676] Patch

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Adam Roben
(:aroben) <aroben at apple.com>'s request for review:
Bug 64455: TestFailures page doesn't show as much information for flaky tests
as I would like, even though the page is already so long
https://bugs.webkit.org/show_bug.cgi?id=64455

Attachment 100676: Patch
https://bugs.webkit.org/attachment.cgi?id=100676&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=100676&action=review


>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewCo
ntroller.js:427
> +	       var disclosureTriangle = document.createElement('span');
> +	       item.appendChild(disclosureTriangle);
> +
> +	       disclosureTriangle.className = 'disclosure-triangle';
> +	       const blackRightPointingSmallTriangle = '\u25b8';
> +	      
disclosureTriangle.appendChild(document.createTextNode(blackRightPointingSmallT
riangle));

you should totally try using details/summary here. If it doesn't work, we
should fix bugs :)