[webkit-reviews] review denied: [Bug 64251] [ShadowContentElement] forwarded node should be able to access its hosting content element. : [Attachment 100666] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 13 08:25:41 PDT 2011


Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied MORITA Hajime
<morrita at google.com>'s request for review:
Bug 64251: [ShadowContentElement] forwarded node should be able to access its
hosting content element.
https://bugs.webkit.org/show_bug.cgi?id=64251

Attachment 100666: Patch
https://bugs.webkit.org/attachment.cgi?id=100666&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=100666&action=review


I am ok with the approach as an iteration, but the bots are angry.

> Source/WebCore/dom/ShadowRoot.cpp:33
> +#include "ShadowContentElement.h" // XXX: should be ShadowInclusion.h or
something

Probably don't want that comment left in :)


More information about the webkit-reviews mailing list