[webkit-reviews] review denied: [Bug 62191] [Qt] Creating webkit2 popup menu hooks and adding popup menus to MiniBrowser. : [Attachment 96787] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 13 06:55:53 PDT 2011


Andreas Kling <kling at webkit.org> has denied Luiz Agostini <luiz at webkit.org>'s
request for review:
Bug 62191: [Qt] Creating webkit2 popup menu hooks and adding popup menus to
MiniBrowser.
https://bugs.webkit.org/show_bug.cgi?id=62191

Attachment 96787: patch
https://bugs.webkit.org/attachment.cgi?id=96787&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
r- because this won't apply after the view class refactoring.

Thinking about this, QWKPopupMenu{,Data} is really not the kind of API we want
to expose to the end-user, but rather something that belongs in a platform
plugin. Popup menus should Just Work(tm) when slapping a QDesktopWebView or
QTouchWebView into your application.


More information about the webkit-reviews mailing list