[webkit-reviews] review granted: [Bug 64379] Web Inspector: do not pause on caught exceptions while typing in the console. : [Attachment 100539] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 64379: Web Inspector: do not pause on caught exceptions while typing in the
console.
https://bugs.webkit.org/show_bug.cgi?id=64379

Attachment 100539: Patch
https://bugs.webkit.org/attachment.cgi?id=100539&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=100539&action=review


r- as WorkerInspectoController also needs change.

> Source/WebCore/inspector/InspectorController.cpp:132
> +   
m_runtimeAgent->setScriptDebugServer(&m_debuggerAgent->scriptDebugServer());

Let's pass reference to ScriptDebugServer into the InspectorRuntimeAgent
constructor. This way compiler will check all call sites and ensure that
ScriptDebugServer is never null.