[webkit-reviews] review denied: [Bug 55046] Share VFP detection for ARM in MacroAssemblerARMCommon class : [Attachment 100105] armcommon.diff

[bugzilla-daemon at webkit.org]

Gavin Barraclough <barraclough at apple.com> has denied Xan Lopez
<xan.lopez at gmail.com>'s request for review:
Bug 55046: Share VFP detection for ARM in MacroAssemblerARMCommon class
https://bugs.webkit.org/show_bug.cgi?id=55046

Attachment 100105: armcommon.diff
https://bugs.webkit.org/attachment.cgi?id=100105&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
Hi xan, this patch is going to add unnecessary dynamic checks on GGC/__VFP_FP__
and RVCT/__TARGET_FPU_VFP platforms, so I'd like to suggest the following:

1) remove s_isVFPPresent for non-LINUX platforms.

2) define isVFPPresent() for non-LINUX platforms as ALWAYS_INLINE & returning a
constant true/false, so that these checks can be compile out.

3) for linux only, define isVFPPresent() to return the value of s_isVFPPresent.



Hope this sounds good.