[webkit-reviews] review granted: [Bug 55158] Use VFP for double to int truncate in ARMv7 : [Attachment 91715] fptruncate.diff

[bugzilla-daemon at webkit.org]

Gavin Barraclough <barraclough at apple.com> has granted Xan Lopez
<xan.lopez at gmail.com>'s request for review:
Bug 55158: Use VFP for double to int truncate in ARMv7
https://bugs.webkit.org/show_bug.cgi?id=55158

Attachment 91715: fptruncate.diff
https://bugs.webkit.org/attachment.cgi?id=91715&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=91715&action=review

Looks great xan.

> Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h:676
> +	   m_assembler.sub_S(dataTempRegister, dest,
ARMThumbImmediate::makeEncodedImm(0x80000000));

Perhaps we should change the signature of this method to take a JumpList, to
avoid the branch-EQ to branch-EQ.  Still, this is a second order issue to
getting branchTruncateDoubleToInt32 doing anything at all!