[webkit-reviews] review granted: [Bug 63688] Refactoring: ExceptionCode value which never become non-zero should be replaced with NeverThrown : [Attachment 100614] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted MORITA Hajime <morrita at google.com>'s
request for review:
Bug 63688: Refactoring: ExceptionCode value which never become non-zero should
be replaced with NeverThrown
https://bugs.webkit.org/show_bug.cgi?id=63688

Attachment 100614: Patch
https://bugs.webkit.org/attachment.cgi?id=100614&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=100614&action=review


> Source/WebCore/dom/ExceptionCodePlaceholder.h:78
> +inline NoExceptionAssertionChecker::NoExceptionAssertionChecker(const char*
file, int line)

Normally when we disable assertions we also disable inlining. I don’t think we
really would want this constructor to be inline if we had a .cpp file to put it
in. Same for the destructor.