[webkit-reviews] review denied: [Bug 64360] Move useRepaintBounds from RenderBlock::layoutRunsAndFloats to LineLayoutState : [Attachment 100483] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jul 12 21:37:24 PDT 2011
MORITA Hajime <morrita at google.com> has denied Chiculita Alexandru
<achicu at adobe.com>'s request for review:
Bug 64360: Move useRepaintBounds from RenderBlock::layoutRunsAndFloats to
LineLayoutState
https://bugs.webkit.org/show_bug.cgi?id=64360
Attachment 100483: Patch
https://bugs.webkit.org/attachment.cgi?id=100483&action=review
------- Additional Comments from MORITA Hajime <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=100483&action=review
> Source/WebCore/rendering/RenderBlockLineLayout.cpp:853
> + bool useRepaintBounds() const { return m_useRepaintBounds; }
"uses" or "shouldUse"? (I know original variable name was wrong....)
> Source/WebCore/rendering/RenderBlockLineLayout.cpp:-1293
> - if (!useRepaintBounds)
Could you elaborate why we don't need this?
More information about the webkit-reviews
mailing list