[webkit-reviews] review granted: [Bug 64403] Move RenderTextControl::indexForVisiblePosition to HTMLTextFormControlElement : [Attachment 100578] Removed unnecessarily includes and forward declarations

[bugzilla-daemon at webkit.org]

MORITA Hajime <morrita at google.com> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 64403: Move RenderTextControl::indexForVisiblePosition to
HTMLTextFormControlElement
https://bugs.webkit.org/show_bug.cgi?id=64403

Attachment 100578: Removed unnecessarily includes and forward declarations
https://bugs.webkit.org/attachment.cgi?id=100578&action=review

------- Additional Comments from MORITA Hajime <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=100578&action=review


> Source/WebCore/editing/htmlediting.cpp:-868
> -    return ancestor != container ? toTextFormControl(ancestor) : 0;

This means |container| has a shadow host, right?
I think "container->sahdowAncestorNode() != container" idiom should represented
as a Node's method (or a local variable at least).
I need to go back and read the Node.cpp to that intention.
(I agree that shadowAncestorNode() is a ugly name. But it's another story...)