[webkit-reviews] review denied: [Bug 64338] Bad filtering of edges on tiled layers : [Attachment 100560] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied  review:
Bug 64338: Bad filtering of edges on tiled layers
https://bugs.webkit.org/show_bug.cgi?id=64338

Attachment 100560: Patch
https://bugs.webkit.org/attachment.cgi?id=100560&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=100560&action=review


I think approach is OK for now.  Please fix up the comments/line wrapping and
post a new patch as soon as you can, currently we have lots of tests marked as
= IMAGE and I'm really concerned that they might regression other, less
acceptable ways.

> Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp:1140
> +    if (static_cast<int>(m_matrix[3][0]) != m_matrix[3][0]
> +	   || static_cast<int>(m_matrix[3][1]) != m_matrix[3][1])

nit: don't line wrap this, or if you do line wrap it make the !=s line up.