[webkit-reviews] review denied: [Bug 64066] DFG JIT does not implement op_construct : [Attachment 100583] the patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 12 16:38:07 PDT 2011


Gavin Barraclough <barraclough at apple.com> has denied Filip Pizlo
<fpizlo at apple.com>'s request for review:
Bug 64066: DFG JIT does not implement op_construct
https://bugs.webkit.org/show_bug.cgi?id=64066

Attachment 100583: the patch
https://bugs.webkit.org/attachment.cgi?id=100583&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
Hey Filip, following on from our conversation earlier, looking at the two bugs
this fixes since the original patch, one looks tougher to test for (error on
unlinking calls), but the other does look testable (virtualFor always compiles
for call).  To test we'd just have to have one function use new, call another,
and have the constructor that is called do something that would prove whether
it was invoked as a call or a constructor (as an example, returning a
non-object value would do).  Unless there is any reason it won't be possible,
let's add a LayoutTest.


More information about the webkit-reviews mailing list