[webkit-reviews] review denied: [Bug 64397] Added the ability to dynamically change the parent context of a WebGraphicsContext3D. : [Attachment 100566] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 12 16:08:17 PDT 2011


Kenneth Russell <kbr at google.com> has denied Al <apatrick at chromium.org>'s
request for review:
Bug 64397: Added the ability to dynamically change the parent context of a
WebGraphicsContext3D.
https://bugs.webkit.org/show_bug.cgi?id=64397

Attachment 100566: Patch
https://bugs.webkit.org/attachment.cgi?id=100566&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=100566&action=review


Please clean up the style issues and re-upload the patch.

> Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp:146
> +    m_impl->setParentContext(m_webViewImpl->graphicsContext3D());

Does this still work if accelerated compositing is turned off (i.e., with the
command line argument --disable-accelerated-compositing)?


More information about the webkit-reviews mailing list