[webkit-reviews] review denied: [Bug 64338] Bad filtering of edges on tiled layers : [Attachment 100499] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jul 12 12:36:53 PDT 2011
Kenneth Russell <kbr at google.com> has denied David Reveman
<reveman at google.com>'s request for review:
Bug 64338: Bad filtering of edges on tiled layers
https://bugs.webkit.org/show_bug.cgi?id=64338
Attachment 100499: Patch
https://bugs.webkit.org/attachment.cgi?id=100499&action=review
------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=100499&action=review
This basically looks fine aside from a naming convention issue.
> Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp:1129
> +bool TransformationMatrix::IsIntegerTranslation() const
This should be named isIntegerTranslation per WebKit style.
> Source/WebCore/platform/graphics/transforms/TransformationMatrix.h:342
> + bool IsIntegerTranslation() const;
Same here.
More information about the webkit-reviews
mailing list