[webkit-reviews] review denied: [Bug 64224] Add popPendingUpdate method to chromium WebWidgetClient. : [Attachment 100536] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied John Bates
<jbates at google.com>'s request for review:
Bug 64224: Add popPendingUpdate method to chromium WebWidgetClient.
https://bugs.webkit.org/show_bug.cgi?id=64224

Attachment 100536: Patch
https://bugs.webkit.org/attachment.cgi?id=100536&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=100536&action=review


Closer!  Please also rename this bug, preferably to describe the problem this
patch fixes (double frames on canvas).

> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp:97
> -void CCLayerTreeHost::updateLayers()
> +void CCLayerTreeHost::syncCompositingLayers()
>  {
> -    m_client->updateLayers();
> +    m_client->syncCompositingLayers();
>  }

delete

> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.h:44
> +    virtual void syncCompositingLayers() = 0;

Just delete this (and the corresponding entry in CCLayerTreeHost), there aren't
any callers of this any more.

> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.h:65
> +    void syncCompositingLayers();

delete

> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.cpp:153

>      m_commitPending = false;
>      {
> -	   TRACE_EVENT("CCLayerTreeHost::updateLayers", this, 0);
> -	   m_layerTreeHost->updateLayers();
> +	   TRACE_EVENT("CCLayerTreeHost::syncCompositingLayers", this, 0);
> +	   m_layerTreeHost->syncCompositingLayers();
>      }

You can delete this section completely, animateAndLayout() takes care of this
now (since it calls WebViewImpl::layout())