[webkit-reviews] review requested: [Bug 64302] [skia] optimize getImageData to avoid a copy when not needed. lockPixels() now does the right thing. : [Attachment 100470] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 12 11:22:41 PDT 2011


Stephen White <senorblanco at chromium.org> has asked  for review:
Bug 64302: [skia] optimize getImageData to avoid a copy when not needed.
lockPixels() now does the right thing.
https://bugs.webkit.org/show_bug.cgi?id=64302

Attachment 100470: Patch
https://bugs.webkit.org/attachment.cgi?id=100470&action=review

------- Additional Comments from Stephen White <senorblanco at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=100470&action=review


> Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp:228
> +	   return result.release();

Just for my own edification:  is this early-out for failure of the
accessBitmap(), the extractSubset() or both?


More information about the webkit-reviews mailing list