[webkit-reviews] review granted: [Bug 63217] Full-screen: Don't change the collectionBehavior of the WebView's NSWindow if not necessary : [Attachment 100370] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 63217: Full-screen: Don't change the collectionBehavior of the WebView's
NSWindow if not necessary
https://bugs.webkit.org/show_bug.cgi?id=63217

Attachment 100370: Patch
https://bugs.webkit.org/attachment.cgi?id=100370&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=100370&action=review


> Source/WebKit2/ChangeLog:9
> +	   collectionBehavior.	The isOnActiveSpace API was added in 10.6, so
skip this check on Leopard.

This comment is now out of date.

> Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm:330
> +	   if (![webWindow isOnActiveSpace]) {

This check needs a why comment.