[webkit-reviews] review denied: [Bug 63688] Refactoring: ExceptionCode value which never become non-zero should be replaced with NeverThrown : [Attachment 100429] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied MORITA Hajime <morrita at google.com>'s
request for review:
Bug 63688: Refactoring: ExceptionCode value which never become non-zero should
be replaced with NeverThrown
https://bugs.webkit.org/show_bug.cgi?id=63688

Attachment 100429: Patch
https://bugs.webkit.org/attachment.cgi?id=100429&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=100429&action=review


review- because of the Windows problem; otherwise looks good

> Source/WebCore/dom/ExceptionCodePlaceholder.h:91
> +#define ASSERT_NO_EXCEPTION ::WebCore::NoExceptionAssertionChecker(__FILE__,
__LINE__, WTF_PRETTY_FUNCTION)

The function-name-finding part of this does not work when the macro is used
outside a function, and on Windows it won’t compile. That’s what the Windows
EWS bot is telling us. I suggest leaving out the function since the vast
majority of uses of this macro will be outside any function. Or you could keep
this and leave out the function names when compiling with the Windows compiler.