[webkit-reviews] review denied: [Bug 64355] max-conns and max-conns-per-host not honored : [Attachment 100492] patch3

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied  review:
Bug 64355: max-conns and max-conns-per-host not honored
https://bugs.webkit.org/show_bug.cgi?id=64355

Attachment 100492: patch3
https://bugs.webkit.org/attachment.cgi?id=100492&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=100492&action=review


Seems like a decent change, but please touch up the ChangeLog a bit.

> Source/WebCore/ChangeLog:6
> +	   max-conns and max-conns-per-host not honored
> +	   https://bugs.webkit.org/show_bug.cgi?id=64355
> +
> +	   Reviewed by NOBODY (OOPS!).

I think this change deserves a line or two explaining what problem this fixes.

> Source/WebCore/ChangeLog:8
> +	   No new tests. (OOPS!)

You should either add a test or explain here why you didn't.

> Source/WebCore/ChangeLog:12
> +	   * platform/network/soup/ResourceHandleSoup.cpp:
> +	   (WebCore::ResourceHandle::defaultSession):
> +

Typically we fill these out.