[webkit-reviews] review denied: [Bug 63987] Bridge RenderBoxModelObject::calculateBackgroundImageGeometry parameters into a class : [Attachment 100464] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied Chiculita Alexandru
<achicu at adobe.com>'s request for review:
Bug 63987: Bridge RenderBoxModelObject::calculateBackgroundImageGeometry
parameters into a class
https://bugs.webkit.org/show_bug.cgi?id=63987

Attachment 100464: Patch
https://bugs.webkit.org/attachment.cgi?id=100464&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=100464&action=review


> Source/WebCore/rendering/RenderBoxModelObject.h:43
> +class BackgroundImageGeometry {

Since this class is only used by RenderBoxModelObject and RenderBox, maybe it
should be declared within the protected section of RenderBoxModelObject?

> Source/WebCore/rendering/RenderBoxModelObject.h:75
> +    IntRect m_destRect;
> +    IntPoint m_phase;
> +    IntSize m_tileSize;

These should be LayoutRect, LayoutPoint and LayoutSize.  The getters/setters
should also be updated.