[webkit-reviews] review granted: [Bug 64358] TestFailures page thinks all tests passed in http://build.webkit.org/builders/Windows%207%20Release%20(Tests)/builds/14672 : [Attachment 100481] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Adam Roben (:aroben)
<aroben at apple.com>'s request for review:
Bug 64358: TestFailures page thinks all tests passed in
http://build.webkit.org/builders/Windows%207%20Release%20(Tests)/builds/14672
https://bugs.webkit.org/show_bug.cgi?id=64358

Attachment 100481: Patch
https://bugs.webkit.org/attachment.cgi?id=100481&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=100481&action=review


>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builde
r.js:156
> +		   result.failureCount = -1;

I take it that you've ensured that the callsites can handle failureCount = -1.
Briefly looking through the code this appears to be true.