[webkit-reviews] review granted: [Bug 64362] [Qt][WK2] Add informative loadFailed() signal to web views. : [Attachment 100493] Proposed patch v3

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Andreas Kling
<kling at webkit.org>'s request for review:
Bug 64362: [Qt][WK2] Add informative loadFailed() signal to web views.
https://bugs.webkit.org/show_bug.cgi?id=64362

Attachment 100493: Proposed patch v3
https://bugs.webkit.org/attachment.cgi?id=100493&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=100493&action=review


>
Source/WebKit2/UIProcess/API/qt/tests/commonviewtests/tst_commonviewtests.cpp:9
0
> +    viewAbstraction->load(QUrl::fromLocalFile(QLatin1String(TESTS_SOURCE_DIR
"/html/kenneth_fanclub_members.html")));

I am not sure that is solid test. I can totally such a page in the tests in the
near future ;)