[webkit-reviews] review granted: [Bug 64214] [chromium] Delete the unused legacy accelerated canvas 2d code : [Attachment 100195] Patch

[bugzilla-daemon at webkit.org]

Stephen White <senorblanco at chromium.org> has granted James Robinson
<jamesr at chromium.org>'s request for review:
Bug 64214: [chromium] Delete the unused legacy accelerated canvas 2d code
https://bugs.webkit.org/show_bug.cgi?id=64214

Attachment 100195: Patch
https://bugs.webkit.org/attachment.cgi?id=100195&action=review

------- Additional Comments from Stephen White <senorblanco at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=100195&action=review


Not your fault, but IWBN if SkGpuDevice could handle all the makeCurrent()'s
internally instead of GraphicsContextSkia.cpp having to do it.

Looks ok.  r=me

> Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp:119
> +    context->platformContext()->makeGrContextCurrent();

Are you sure this one is still needed?	useGPU() is always false for Ganesh, so
this whole clause should probably go away.

> Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp:127
> +    context->platformContext()->makeGrContextCurrent();

This wasn't here before.. was this a bug?  Or is the lower level no longer
doing a makeGrContextCurrent?

> Source/WebCore/platform/graphics/skia/PlatformContextSkia.h:74
>	   SkiaGPU

Nit:  could be demoted to a bool, or perhaps even removed (m_gpuContext != NULL
could be used, I think).

> Source/WebCore/platform/graphics/skia/PlatformContextSkia.h:183
>      bool canAccelerate() const;

Do we still need this?