[webkit-reviews] review denied: [Bug 64357] [Qt] Forward the touch view scale changes to the tiled drawing area. : [Attachment 100480] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied  review:
Bug 64357: [Qt] Forward the touch view scale changes to the tiled drawing area.
https://bugs.webkit.org/show_bug.cgi?id=64357

Attachment 100480: Patch
https://bugs.webkit.org/attachment.cgi?id=100480&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=100480&action=review


> Source/WebKit2/UIProcess/API/qt/qtouchwebpage.cpp:182
> +    page->setContentsScale(q->scale());

I would prefer you stop the m_scaleCommitTimer here instead of in
QTouchWebPage::timerEvent().
Otherwise it might timeout after the commitScaleChange and you get a second
call commitScaleChange, and the assertion would fail.