[webkit-reviews] review denied: [Bug 64283] Web Inspector: Focusing on another node while editing CSS property does not update styles : [Attachment 100309] [PATCH] Suggested fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 12 05:19:34 PDT 2011


Pavel Feldman <pfeldman at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 64283: Web Inspector: Focusing on another node while editing CSS property
does not update styles
https://bugs.webkit.org/show_bug.cgi?id=64283

Attachment 100309: [PATCH] Suggested fix
https://bugs.webkit.org/attachment.cgi?id=100309&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=100309&action=review


> Source/WebCore/inspector/front-end/StylesSidebarPane.js:1969
> +		   WebInspector.panels.elements.startEditingStyle();

There is no guarantee that endEditingStyle is going to be called. Can we add an
"editing" state that we enter once upon start editing and exit upon canceling /
navigating out of the rule?


More information about the webkit-reviews mailing list