[webkit-reviews] review requested: [Bug 45395] [GTK] DOM bindings do not have gir annotations : [Attachment 100448] patch for issue 3

[bugzilla-daemon at webkit.org]

arno. <arno at renevier.net> has asked  for review:
Bug 45395: [GTK] DOM bindings do not have gir annotations
https://bugs.webkit.org/show_bug.cgi?id=45395

Attachment 100448: patch for issue 3
https://bugs.webkit.org/attachment.cgi?id=100448&action=review

------- Additional Comments from arno. <arno at renevier.net>
(In reply to comment #8)
> (From update of attachment 100360 [details])

> > Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:791
> > +	 $selfClass =~ s/\*$//;
> 
> I think $className does not end in *, so this seems redundant.

fixed
 
> > Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:795
> > +	     my $paramIDLType = $param->type;
> 
> Minor nit, probably you can do without this variable.

fixed

> > Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:797
> > +	     $paramType =~ s/\*$//;	   
> 
> Same than first comment.

fixed

> > Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:806
> > +	     push(@hBody, " * Returns: (transfer none):\n");	
> 
> Answering to your question, this is OK. GDOM objects are GC by WebKit
automatically, so there's no need to manually unref them. transfer: full would
also be OK, since it's possibly to unref them manually too. So AFAIK this is
mostly up to us. transfer none is probably safer, so I think we can start with
that.

ok, thanks for your answer.
Here is a new patch with a changelog. I fell like I'm "hijacking" Gabriel's
patch but hopefully, that will help getting annotations for dom methods.
Also, I 
push(@hBody, " * Returns:\n");
if return type is not dom class type.