[webkit-reviews] review granted: [Bug 62536] [EFL] Supports to execute "redo" command. : [Attachment 100436] New patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 11 22:17:09 PDT 2011


Ryosuke Niwa <rniwa at webkit.org> has granted Jaehun Lim
<ljaehun.lim at samsung.com>'s request for review:
Bug 62536: [EFL] Supports to execute "redo" command.
https://bugs.webkit.org/show_bug.cgi?id=62536

Attachment 100436: New patch
https://bugs.webkit.org/attachment.cgi?id=100436&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=100436&action=review


> Source/WebKit/efl/WebCoreSupport/EditorClientEfl.cpp:167
> +    if (!m_isInRedo)
> +	   redoStack.clear();

Now, this makes a lot of sense!

> Source/WebKit/efl/WebCoreSupport/EditorClientEfl.cpp:218
> +	   m_isInRedo = true;
> +	   command->reapply();
> +	   m_isInRedo = false;

I must say that this is likely broken if scripts run execCommand in mutation
events but I suppose all other ports have the same issue ? :(


More information about the webkit-reviews mailing list