[webkit-reviews] review requested: [Bug 62840] Optimize HTMLInputElement::updateCheckedRadioButtons : [Attachment 100433] new patch

[bugzilla-daemon at webkit.org]

zeng huiqing <huiqing.zeng at intel.com> has asked  for review:
Bug 62840: Optimize HTMLInputElement::updateCheckedRadioButtons
https://bugs.webkit.org/show_bug.cgi?id=62840

Attachment 100433: new patch
https://bugs.webkit.org/attachment.cgi?id=100433&action=review

------- Additional Comments from zeng huiqing <huiqing.zeng at intel.com>
Many thanks for helping review the patch and the good comments:)

1)I have changed 'if(type()!=(InputTypeNames::checkbox()))' to
'if(type()==(InputTypeNames::radio()))', but I'm sorry that I'm not sure that
besides 'radio', we don't need to call updateCheckedRadioButtons() for all the
other types of input element?

2)The next attachement is the micro-benchmark I use to test the page loading
performance, run "./chrome --allow-file-access-from-files
omedia_workload4_iterations_rev5x5.html" to get the result, and the result
shows that Chromium(build 91994) w/ patch ~1.3x faster to load page
radio.html(heavily using 'radio').
My test Platform: 4G i7 860 Ubuntu 10.04