[webkit-reviews] review denied: [Bug 64224] Add popPendingUpdate method to chromium WebWidgetClient. : [Attachment 100401] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 11 18:16:03 PDT 2011


James Robinson <jamesr at chromium.org> has denied John Bates
<jbates at google.com>'s request for review:
Bug 64224: Add popPendingUpdate method to chromium WebWidgetClient.
https://bugs.webkit.org/show_bug.cgi?id=64224

Attachment 100401: Patch
https://bugs.webkit.org/attachment.cgi?id=100401&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
Wait, it's not valid to call LayerRendererChromium::updateLayers() at this
point.	You want to just call WebViewImpl's updateLayers(), which does a
different thing, and remove that call from LayerRendererChromium.  Leave
doComposite() alone.

Also, this bug needs to be retitled.


More information about the webkit-reviews mailing list