[webkit-reviews] review granted: [Bug 64157] AudioDevice::Stop can close NULL handle. : [Attachment 100382] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Chris Rogers
<crogers at google.com>'s request for review:
Bug 64157: AudioDevice::Stop can close NULL handle.
https://bugs.webkit.org/show_bug.cgi?id=64157

Attachment 100382: Patch
https://bugs.webkit.org/attachment.cgi?id=100382&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=100382&action=review


Basically looks good except for a small issue in the bindings.

> Source/WebCore/bindings/js/JSAudioContextCustom.cpp:72
> +	       return throwVMError(exec, createReferenceError(exec, "audio
resources unavailable for AudioContext construction"));

The JS bindings are throwing a ReferenceError, while the V8 bindings are
throwing a SyntaxError. These should be aligned.