[webkit-reviews] review granted: [Bug 62536] [EFL] Supports to execute "redo" command. : [Attachment 100375] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 11 15:59:39 PDT 2011


Ryosuke Niwa <rniwa at webkit.org> has granted Jaehun Lim
<ljaehun.lim at samsung.com>'s request for review:
Bug 62536: [EFL] Supports to execute "redo" command.
https://bugs.webkit.org/show_bug.cgi?id=62536

Attachment 100375: Patch
https://bugs.webkit.org/attachment.cgi?id=100375&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=100375&action=review


> Source/WebKit/efl/WebCoreSupport/EditorClientEfl.cpp:214
> +	   ASSERT(!m_isInRedo);
> +	   m_isInRedo = true;

I'm still not happy about the fact there's asymmetry between undo and redo.


More information about the webkit-reviews mailing list