[webkit-reviews] review requested: [Bug 57154] [Qt] Make OpenGL symbol resolver transparent : [Attachment 100349] updated Jarkkos patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 11 12:31:30 PDT 2011


Andrew Wason <rectalogic at rectalogic.com> has asked  for review:
Bug 57154: [Qt] Make OpenGL symbol resolver transparent
https://bugs.webkit.org/show_bug.cgi?id=57154

Attachment 100349: updated Jarkkos patch
https://bugs.webkit.org/attachment.cgi?id=100349&action=review

------- Additional Comments from Andrew Wason <rectalogic at rectalogic.com>
Some additional cleanup realized while working on bug 57261

Move the destruction of members owned by GraphicsContext3D from
~GraphicsContext3DInternal to ~GraphicsContext3D.

Define proc members for QT_OPENGL_ES_2 too - so we can always access them via
the context - this removes extra conditional code from other classes that need
to access the procs via m_context.


More information about the webkit-reviews mailing list