[webkit-reviews] review denied: [Bug 64301] Switch transform operations to LayoutSize : [Attachment 100338] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Levi Weintraub <leviw at chromium.org>'s
request for review:
Bug 64301: Switch transform operations to LayoutSize
https://bugs.webkit.org/show_bug.cgi?id=64301

Attachment 100338: Patch
https://bugs.webkit.org/attachment.cgi?id=100338&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=100338&action=review


Otherwise looks fine.

> Source/WebCore/platform/Length.h:158
> +	   default:
> +	       return static_cast<float>(undefinedLength);

Normally we don't use default: cases for switch(enum), but maybe it makes sense
here?

> Source/WebCore/platform/Length.h:162
> +    float calcFloatValue(float maxValue) const

Did you copy paste this same function twice?