[webkit-reviews] review requested: [Bug 56200] [GTK] WebKitIconDatabase doesn't keep icons cached : [Attachment 100340] Updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 11 11:51:30 PDT 2011


Carlos Garcia Campos <cgarcia at igalia.com> has asked  for review:
Bug 56200: [GTK] WebKitIconDatabase doesn't keep icons cached
https://bugs.webkit.org/show_bug.cgi?id=56200

Attachment 100340: Updated patch
https://bugs.webkit.org/attachment.cgi?id=100340&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
This patch adds async api to get a pixbuf, since Xan told me it's required by
ephy history and bookmarks that need an api to get a pixbuf without having to
connect to icon-loaded signal. It also fixes some docs comments, and adds unit
tests for WebIconDatabase.


More information about the webkit-reviews mailing list