[webkit-reviews] review granted: [Bug 63286] Add NSURLResponse wrapper in ResourceResponse when USE(CFNETWORK) is enabled : [Attachment 98943] Patch v3 - fixes some layout tests by creating correct NSURLResponses

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Pratik Solanki
<psolanki at apple.com>'s request for review:
Bug 63286: Add NSURLResponse wrapper in ResourceResponse when USE(CFNETWORK) is
enabled
https://bugs.webkit.org/show_bug.cgi?id=63286

Attachment 98943: Patch v3 - fixes some layout tests by creating correct
NSURLResponses
https://bugs.webkit.org/attachment.cgi?id=98943&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=98943&action=review

r=me

> Source/WebCore/platform/network/mac/ResourceResponseMac.mm:56
> +    // Work around a mistake in the NSURLResponse class.

Would be nice to document this as <rdar://problem/3346574> (per our discussion
on IRC).

> Source/WebCore/platform/network/mac/ResourceResponseMac.mm:77
> +    if (!m_cfResponse)
> +	   return nil;

Is there ever a case where you have an m_nsResponse but not a m_cfResponse (in
which case you could make the m_cfResponse from the m_nsResponse)?  Or is this
ASSERT-ed elsewhere during construction so it's not possible to get into this
state?

Could some of this logic be simplified by doing an early return if m_isNull is
true:

    if (m_isNull)
	return nil;