[webkit-reviews] review granted: [Bug 64281] [skia] remove platform helpers for gradients and patterns : [Attachment 100305] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 11 10:30:46 PDT 2011


Stephen White <senorblanco at chromium.org> has granted Mike Reed
<reed at google.com>'s request for review:
Bug 64281: [skia] remove platform helpers for gradients and patterns
https://bugs.webkit.org/show_bug.cgi?id=64281

Attachment 100305: Patch
https://bugs.webkit.org/attachment.cgi?id=100305&action=review

------- Additional Comments from Stephen White <senorblanco at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=100305&action=review


Thanks for the cleanup.  r=me

> Source/WebCore/platform/graphics/skia/PlatformContextSkia.cpp:376
> +					 SkColor color) const {

Nit:  Don't wrap at 80 cols.

> Source/WebCore/platform/graphics/skia/PlatformContextSkia.cpp:397
> +		   m_state->m_fillColor);

Nit:  Don't wrap at 80 cols.

> Source/WebCore/platform/graphics/skia/PlatformContextSkia.cpp:406
> +		   m_state->m_strokeColor);

Nit:  Don't wrap at 80 cols.

> Source/WebCore/platform/graphics/skia/PlatformContextSkia.h:86
> +    void setGraphicsContext(const GraphicsContext* gc) { m_gc = gc; }

This is a bit circular, but I guess it's ok.  We had avoided the need for a
backpointer up until now, but I think the cleaner approach in the rest of your
patch justifies a circular reference.


More information about the webkit-reviews mailing list