[webkit-reviews] review requested: [Bug 27551] Make it possible to build JavaScriptCore as shared library without symbol lists : [Attachment 100313] Complete set of JS_EXPORT_PRIVATE and WTF_EXPORT_PRIVATE macro additions

[bugzilla-daemon at webkit.org]

Kevin Ollivier <kevino at theolliviers.com> has asked  for review:
Bug 27551: Make it possible to build JavaScriptCore as shared library without
symbol lists
https://bugs.webkit.org/show_bug.cgi?id=27551

Attachment 100313: Complete set of JS_EXPORT_PRIVATE and WTF_EXPORT_PRIVATE
macro additions
https://bugs.webkit.org/attachment.cgi?id=100313&action=review

------- Additional Comments from Kevin Ollivier <kevino at theolliviers.com>
Thanks Adam for offering to Rubber Stamp this! A couple notes:

1) The export macros we're using right now are JS_EXPORT_PRIVATE and
WTF_EXPORT_PRIVATE. This is so that we can define them to nothing on any port
that hasn't moved over yet to ease transition and keep ports that rely on the
existing macros from having breakages. Once all the ports are moved over, these
macros and JS_EXPORTDATA / JS_EXPORTCLASS will be merged into one macro each
for JS and WTF. 

2) There are a few style failures remaining. I can fix these in a subsequent
patch, but I didn't change them now because most of them are namespace
indentation issues which would cause the patch to show every line in the file
as changed, and hence you wouldn't be able to confirm they are all macro
additions any longer. The one other remaining style issue is saying I should
switch RefPtr to PassRefPtr, but I wasn't sure if that might affect runtime
behavior and I felt that would take the patch outside of the scope in which
people would be willing to rubber stamp it. 

Thanks again, and sorry this took time, I've been pretty busy recently.