[webkit-reviews] review denied: [Bug 62935] [GTK] Fix GTK unit tests failures when WebKit is build outside repository directory. : [Attachment 98142] Patch2

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has denied Lukasz Slachciak
<l.slachciak at samsung.com>'s request for review:
Bug 62935: [GTK] Fix GTK unit tests failures when WebKit is build outside
repository directory.
https://bugs.webkit.org/show_bug.cgi?id=62935

Attachment 98142: Patch2
https://bugs.webkit.org/attachment.cgi?id=98142&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=98142&action=review

> Source/WebKit/gtk/tests/test_utils.c:34
> +    /* user can set location of the webkit repository directory if it
differs from build directory */
> +    const char* repo_path = g_getenv("WEBKITREPODIR");
> +    if (repo_path) {
> +	   if (g_chdir(repo_path)) {
> +	    return -1;
> +	}
> +    }
> +    else if (g_path_is_absolute(executable_path)) {

Indentation seems quite off here, or is it the patch viewer? The inner if
should not have bracers (this file has plenty of this problem, unfortunately),
and the else if should be in the same line as the }. Also, given this is a C
file, the * should be on the right side. What do you think of doing a style
cleanup on this file? ;)