[webkit-reviews] review denied: [Bug 64262] Small speed up, which switches some virtual functions to inline ones. : [Attachment 100268] Small speed up, which switches some virtual functions to inline ones.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 11 06:05:41 PDT 2011


Zoltan Herczeg <zherczeg at webkit.org> has denied Czene Tamas
<Czene.Tamas at stud.u-szeged.hu>'s request for review:
Bug 64262: Small speed up, which switches some virtual functions to inline
ones.
https://bugs.webkit.org/show_bug.cgi?id=64262

Attachment 100268: Small speed up, which switches some virtual functions to
inline ones.
https://bugs.webkit.org/attachment.cgi?id=100268&action=review

------- Additional Comments from Zoltan Herczeg <zherczeg at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=100268&action=review


> Source/WebCore/css/CSSImageGeneratorValue.h:53
>      virtual IntSize fixedSize(const RenderObject*) { return IntSize(); }

Such function must remain virtal, as it can be called from its base class (if
exists), or from its descendants. I would not overwrite them except if we got a
permission from the author of those functions, and done them one-by-one.

There are several others like this.


More information about the webkit-reviews mailing list