[webkit-reviews] review denied: [Bug 62477] Web Inspector: [refactoring] Remove dependencies of components requiring network resource list from network panel : [Attachment 100269] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jul 11 05:22:39 PDT 2011
Pavel Feldman <pfeldman at chromium.org> has denied Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 62477: Web Inspector: [refactoring] Remove dependencies of components
requiring network resource list from network panel
https://bugs.webkit.org/show_bug.cgi?id=62477
Attachment 100269: patch
https://bugs.webkit.org/attachment.cgi?id=100269&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=100269&action=review
> Source/WebCore/inspector/front-end/NetworkManager.js:330
> + return this._resources;
I'd rather further encapsulate "resources" (via addResource) since you swap the
instance in the frameNavigated.
More information about the webkit-reviews
mailing list