[webkit-reviews] review requested: [Bug 62840] Optimize HTMLInputElement::updateCheckedRadioButtons : [Attachment 100267] fix the checkbox issue & improve updateCheckedRadioButtons()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 11 04:51:02 PDT 2011


zeng huiqing <huiqing.zeng at intel.com> has asked  for review:
Bug 62840: Optimize HTMLInputElement::updateCheckedRadioButtons
https://bugs.webkit.org/show_bug.cgi?id=62840

Attachment 100267: fix the checkbox issue & improve updateCheckedRadioButtons()
https://bugs.webkit.org/attachment.cgi?id=100267&action=review

------- Additional Comments from zeng huiqing <huiqing.zeng at intel.com>
I have added an attachment to fix the bug:
1)in function HTMLInputElement::setChecked(...)
add "if(type()!=(InputTypeNames::checkbox()))' to avoid the unnecessary update
for checkbox".

2)in function HTMLInputElement::updateCheckedRadioButtons()
replace traversing document()->body() with Document::m_formElementsWithState to
improve the performance.


More information about the webkit-reviews mailing list