[webkit-reviews] review denied: [Bug 64097] Web Inspector: Add support for disabling cache in web inspector. : [Attachment 100126] Patch (mac fix)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 11 04:42:59 PDT 2011


Pavel Feldman <pfeldman at chromium.org> has denied Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 64097: Web Inspector: Add support for disabling cache in web inspector.
https://bugs.webkit.org/show_bug.cgi?id=64097

Attachment 100126: Patch (mac fix)
https://bugs.webkit.org/attachment.cgi?id=100126&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=100126&action=review


> Source/WebCore/inspector/InspectorResourceAgent.cpp:433
> +   
memoryCache()->setDisabled(m_state->getBoolean(ResourceAgentState::cacheDisable
d));

I'd rather introduce memoryCache()->setDisabledByInspector().


More information about the webkit-reviews mailing list