[webkit-reviews] review granted: [Bug 63317] Web Inspector: console.markTimeline vs. console.timeStamp : [Attachment 100264] Dropping console warning.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 11 04:41:21 PDT 2011


Pavel Feldman <pfeldman at chromium.org> has granted Mike West
<mkwst at chromium.org>'s request for review:
Bug 63317: Web Inspector: console.markTimeline vs. console.timeStamp
https://bugs.webkit.org/show_bug.cgi?id=63317

Attachment 100264: Dropping console warning.
https://bugs.webkit.org/attachment.cgi?id=100264&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=100264&action=review


> LayoutTests/inspector/timeline/timeline-enum-stability-expected.txt:17
> +    TimeStamp : "TimeStamp"

This is likely to harm SpeedTracer, we should let them know we are breaking api
here.

> LayoutTests/inspector/timeline/timeline-time-stamp-expected.txt:1
> +Tests the Timeline API timeStamp feature

It'll need chromium baseline, but WK sheriff will do one for you.


More information about the webkit-reviews mailing list