[webkit-reviews] review denied: [Bug 63317] Web Inspector: console.markTimeline vs. console.timeStamp : [Attachment 100215] I didn't realize we had Chromium platform tests... Now I do.

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Mike West
<mkwst at chromium.org>'s request for review:
Bug 63317: Web Inspector: console.markTimeline vs. console.timeStamp
https://bugs.webkit.org/show_bug.cgi?id=63317

Attachment 100215: I didn't realize we had Chromium platform tests... Now I do.
https://bugs.webkit.org/attachment.cgi?id=100215&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=100215&action=review


One comment, otherwise looks good.

> Source/WebCore/page/Console.cpp:258
> +    String consoleMessage = "console.markTimeline() is deprecated. Please
use console.timeStamp() instead.\n";

I can see Closure JS library using this method, I can also see a couple of
production web apps using it (Google Maps, GMail, etc.). Extensive console
logging will affect site performance, so I'd rather:

- make it silently delegate to timeStamp here
- deprecate it in all the docs possible
- fix Closure and suggest Maps and Gmail migrating to the new solution (they
will benefit via Firebug support).

Then we will be able to either put logging here or nuke the method altogether.