[webkit-reviews] review denied: [Bug 64242] WebSocket: Copy existing WebSocket tests : [Attachment 100234] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Jul 10 20:09:28 PDT 2011
Yuta Kitamura <yutak at chromium.org> has denied Yuta Kitamura
<yutak at chromium.org>'s request for review:
Bug 64242: WebSocket: Copy existing WebSocket tests
https://bugs.webkit.org/show_bug.cgi?id=64242
Attachment 100234: Patch
https://bugs.webkit.org/attachment.cgi?id=100234&action=review
------- Additional Comments from Yuta Kitamura <yutak at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=100234&action=review
>> LayoutTests/platform/win/Skipped:1355
>> +http/tests/websocket/tests/alert-in-event-handler.html
>
> I prefer copy the tests into a subdirectory such as
http/tests/websocket/tets/hybi/, and skip the directory.
> Yuta-san, what do you think?
Sure, that sounds better to me, too. I will update the patch.
More information about the webkit-reviews
mailing list